On Fri, 2020-05-01 at 21:22 +0300, Denis Efremov wrote:

On 5/1/20 9:02 PM, Joe Perches wrote:

quoted

On Fri, 2020-05-01 at 16:44 +0300, Denis Efremov wrote:

quoted

These patches are based on Willy's cleanup patches
https://lkml.org/lkml/2020/3/31/609.

Maybe add pr_fmt and clean up a few messages so
all the logging output is prefixed too.

Yes, I'm preparing next patchset with almost the same pr_fmt patch in it.
However, simply adding pr_fmt is not enough. We need to remove DPRINT macro
from the driver because it uses current_drive and this is wrong after Willy's cleanups.

#define DPRINT(format, args...) \                                                
        pr_info("floppy%d: " format, current_drive, ##args)

I also don't like debug_dcl and how it is used.

great, thanks.