Re: [PATCH 4/9] scsi_debug: support host tagset
From: Douglas Gilbert <dgilbert@interlog.com>
Date: 2019-06-02 17:07:56
On 2019-05-30 10:27 p.m., Ming Lei wrote:
The 'host_tagset' can be set on scsi_debug device for testing shared hostwide tags on multiple blk-mq hw queue. Signed-off-by: Ming Lei <redacted>
Hi, Attached are my suggestions to clean up this patch a bit. It basically - drops the unneeded initialization (pointed out in another review) - places new module_param_named() in alphabetical order - adds MODULE_PARM_DESC() for 'modinfo scsi_debug' online help Doug Gilbert
quoted hunk ↗ jump to hunk
--- drivers/scsi/scsi_debug.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c index d323523f5f9d..8cf3f6c3f4f9 100644 --- a/drivers/scsi/scsi_debug.c +++ b/drivers/scsi/scsi_debug.c@@ -665,6 +665,7 @@ static bool have_dif_prot; static bool write_since_sync; static bool sdebug_statistics = DEF_STATISTICS; static bool sdebug_wp; +static bool sdebug_host_tagset = false; static unsigned int sdebug_store_sectors; static sector_t sdebug_capacity; /* in sectors */@@ -4468,6 +4469,7 @@ module_param_named(vpd_use_hostno, sdebug_vpd_use_hostno, int, module_param_named(wp, sdebug_wp, bool, S_IRUGO | S_IWUSR); module_param_named(write_same_length, sdebug_write_same_length, int, S_IRUGO | S_IWUSR); +module_param_named(host_tagset, sdebug_host_tagset, bool, S_IRUGO | S_IWUSR); MODULE_AUTHOR("Eric Youngdale + Douglas Gilbert"); MODULE_DESCRIPTION("SCSI debug adapter driver");@@ -5779,6 +5781,7 @@ static int sdebug_driver_probe(struct device *dev) sdbg_host = to_sdebug_host(dev); sdebug_driver_template.can_queue = sdebug_max_queue; + sdebug_driver_template.host_tagset = sdebug_host_tagset; if (!sdebug_clustering) sdebug_driver_template.dma_boundary = PAGE_SIZE - 1;
Attachments
- 0002-sg-convert-to-blk_mq-hw-queue-Ming-Lei.patch [text/x-patch] 2266 bytes · preview