Re: [PATCH 1/9] blk-mq: allow hw queues to share hostwide tags
From: Bart Van Assche <bvanassche@acm.org>
Date: 2019-05-31 15:37:43
On 5/30/19 7:27 PM, Ming Lei wrote:
quoted hunk ↗ jump to hunk
diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c index 6aea0ebc3a73..3d6780504dcb 100644 --- a/block/blk-mq-debugfs.c +++ b/block/blk-mq-debugfs.c@@ -237,6 +237,7 @@ static const char *const alloc_policy_name[] = { static const char *const hctx_flag_name[] = { HCTX_FLAG_NAME(SHOULD_MERGE), HCTX_FLAG_NAME(TAG_SHARED), + HCTX_FLAG_NAME(HOST_TAGS), HCTX_FLAG_NAME(BLOCKING), HCTX_FLAG_NAME(NO_SCHED), };
The name BLK_MQ_F_HOST_TAGS suggests that tags are shared across a SCSI host. That is misleading since this flag means that tags are shared across hardware queues. Additionally, the "host" term is a term that comes from the SCSI world and this patch is a block layer patch. That makes me wonder whether another name should be used to reflect that all hardware queues share the same tag set? How about renaming BLK_MQ_F_TAG_SHARED into BLK_MQ_F_TAG_QUEUE_SHARED and renaming BLK_MQ_F_HOST_TAGS into BLK_MQ_F_TAG_HCTX_SHARED? Bart.