Thread (41 messages) 41 messages, 5 authors, 2018-12-04

Re: [PATCH 02/13] nvme-pci: use atomic bitops to mark a queue enabled

From: Sagi Grimberg <sagi@grimberg.me>
Date: 2018-12-04 17:11:32
Also in: linux-nvme

quoted
quoted
@@ -2173,6 +2157,8 @@ static int nvme_setup_io_queues(struct nvme_dev *dev)
     	if (nr_io_queues == 0)
   		return 0;
+	
+	clear_bit(NVMEQ_ENABLED, &adminq->flags);
   
This is a change of behavior, looks correct though as we can fail
nvme_setup_irqs after we freed the admin vector. Needs documentation
though..
I have a hard time parsing the above, can you point to where the problem
is?
This flag replaces cq_vector = -1 for indicating the queue state so I'd
expect that it would not appear where the former didn't. In this case
we clear the flag in a place that before we did not set the cq_vector
before, which seems correct to me though.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help