Re: [PATCH 06/13] nvme-pci: refactor nvme_disable_io_queues
From: Sagi Grimberg <sagi@grimberg.me>
Date: 2018-12-04 01:01:03
Also in:
linux-nvme
quoted hunk ↗ jump to hunk
@@ -2428,7 +2426,8 @@ static void nvme_dev_disable(struct nvme_dev *dev, bool shutdown) nvme_stop_queues(&dev->ctrl); if (!dead && dev->ctrl.queue_count > 0) { - nvme_disable_io_queues(dev); + if (nvme_disable_io_queues(dev, nvme_admin_delete_sq)) +
Would be nice if the opcode change would be kept inside but still
split like:
static void nvme_disable_io_queues(struct nvme_dev *dev)
{
if (__nvme_disable_io_queues(dev, nvme_admin_delete_sq))
__nvme_disable_io_queues(dev, nvme_admin_delete_cq);
}