Re: [PATCH 24/26] fs: add support for mapping an ITER_BVEC for O_DIRECT

[PATCHSET v8] Support for polled and buffered aio (and more) · Jens Axboe <axboe@kernel.dk> · 2018-12-13
[PATCH 01/26] fs: add an iopoll method to struct file_operations · Jens Axboe <axboe@kernel.dk> · 2018-12-13
[PATCH 02/26] block: add REQ_HIPRI_ASYNC · Jens Axboe <axboe@kernel.dk> · 2018-12-13
[PATCH 03/26] block: wire up block device iopoll method · Jens Axboe <axboe@kernel.dk> · 2018-12-13
[PATCH 04/26] block: use REQ_HIPRI_ASYNC for non-sync polled IO · Jens Axboe <axboe@kernel.dk> · 2018-12-13
[PATCH 05/26] iomap: wire up the iopoll method · Jens Axboe <axboe@kernel.dk> · 2018-12-13
[PATCH 06/26] aio: use assigned completion handler · Jens Axboe <axboe@kernel.dk> · 2018-12-13
[PATCH 07/26] aio: separate out ring reservation from req allocation · Jens Axboe <axboe@kernel.dk> · 2018-12-13
[PATCH 08/26] aio: don't zero entire aio_kiocb aio_get_req() · Jens Axboe <axboe@kernel.dk> · 2018-12-13
[PATCH 09/26] aio: only use blk plugs for > 2 depth submissions · Jens Axboe <axboe@kernel.dk> · 2018-12-13
[PATCH 10/26] aio: use iocb_put() instead of open coding it · Jens Axboe <axboe@kernel.dk> · 2018-12-13
[PATCH 11/26] aio: split out iocb copy from io_submit_one() · Jens Axboe <axboe@kernel.dk> · 2018-12-13
Re: [PATCH 11/26] aio: split out iocb copy from io_submit_one() · Christoph Hellwig <hch@lst.de> · 2018-12-16
[PATCH 12/26] aio: abstract out io_event filler helper · Jens Axboe <axboe@kernel.dk> · 2018-12-13
Re: [PATCH 12/26] aio: abstract out io_event filler helper · Christoph Hellwig <hch@lst.de> · 2018-12-16
[PATCH 13/26] aio: add io_setup2() system call · Jens Axboe <axboe@kernel.dk> · 2018-12-13
[PATCH 14/26] aio: support for IO polling · Jens Axboe <axboe@kernel.dk> · 2018-12-13
Re: [PATCH 14/26] aio: support for IO polling · Benny Halevy <hidden> · 2018-12-18
Re: [PATCH 14/26] aio: support for IO polling · Jens Axboe <axboe@kernel.dk> · 2018-12-18
Re: [PATCH 14/26] aio: support for IO polling · Benny Halevy <hidden> · 2018-12-18
Re: [PATCH 14/26] aio: support for IO polling · Jens Axboe <axboe@kernel.dk> · 2018-12-18
[PATCH 15/26] aio: add submission side request cache · Jens Axboe <axboe@kernel.dk> · 2018-12-13
[PATCH 16/26] fs: add fget_many() and fput_many() · Jens Axboe <axboe@kernel.dk> · 2018-12-13
Re: [PATCH 16/26] fs: add fget_many() and fput_many() · Christoph Hellwig <hch@lst.de> · 2018-12-16
Re: [PATCH 16/26] fs: add fget_many() and fput_many() · Jens Axboe <axboe@kernel.dk> · 2018-12-16
[PATCH 17/26] aio: use fget/fput_many() for file references · Jens Axboe <axboe@kernel.dk> · 2018-12-13
[PATCH 18/26] aio: split iocb init from allocation · Jens Axboe <axboe@kernel.dk> · 2018-12-13
[PATCH 19/26] aio: batch aio_kiocb allocation · Jens Axboe <axboe@kernel.dk> · 2018-12-13
[PATCH 20/26] aio: split old ring complete out from aio_complete() · Jens Axboe <axboe@kernel.dk> · 2018-12-13
[PATCH 21/26] aio: add support for submission/completion rings · Jens Axboe <axboe@kernel.dk> · 2018-12-13
[PATCH 22/26] block: add BIO_HOLD_PAGES flag · Jens Axboe <axboe@kernel.dk> · 2018-12-13
[PATCH 23/26] block: implement bio helper to add iter bvec pages to bio · Jens Axboe <axboe@kernel.dk> · 2018-12-13
Re: [PATCH 23/26] block: implement bio helper to add iter bvec pages to bio · Christoph Hellwig <hch@lst.de> · 2018-12-16
Re: [PATCH 23/26] block: implement bio helper to add iter bvec pages to bio · Jens Axboe <axboe@kernel.dk> · 2018-12-16
[PATCH 24/26] fs: add support for mapping an ITER_BVEC for O_DIRECT · Jens Axboe <axboe@kernel.dk> · 2018-12-13
Re: [PATCH 24/26] fs: add support for mapping an ITER_BVEC for O_DIRECT · Christoph Hellwig <hch@lst.de> · 2018-12-16
Re: [PATCH 24/26] fs: add support for mapping an ITER_BVEC for O_DIRECT · Jens Axboe <axboe@kernel.dk> · 2018-12-16
[PATCH 25/26] aio: add support for pre-mapped user IO buffers · Jens Axboe <axboe@kernel.dk> · 2018-12-13
[PATCH 26/26] aio: support kernel side submission for aio with SCQRING · Jens Axboe <axboe@kernel.dk> · 2018-12-13
Re: [PATCHSET v8] Support for polled and buffered aio (and more) · Christoph Hellwig <hch@lst.de> · 2018-12-16
Re: [PATCHSET v8] Support for polled and buffered aio (and more) · Jens Axboe <axboe@kernel.dk> · 2018-12-16
Re: [PATCHSET v8] Support for polled and buffered aio (and more) · Christoph Hellwig <hch@lst.de> · 2018-12-16
Re: [PATCHSET v8] Support for polled and buffered aio (and more) · Jens Axboe <axboe@kernel.dk> · 2018-12-16
Re: [PATCHSET v8] Support for polled and buffered aio (and more) · Christoph Hellwig <hch@lst.de> · 2018-12-16

From: Christoph Hellwig <hch@lst.de>
Date: 2018-12-16 16:41:31
Also in: linux-fsdevel

+	if (iov_iter_is_bvec(iter))
+		ret = bio_iov_bvec_add_pages(&bio, iter);
+	else
+		ret = bio_iov_iter_get_pages(&bio, iter);

Shouldn't this actually be done inside bio_iov_iter_get_pages?

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help