On 12/16/18 9:41 AM, Christoph Hellwig wrote:

quoted

+	if (iov_iter_is_bvec(iter))
+		ret = bio_iov_bvec_add_pages(&bio, iter);
+	else
+		ret = bio_iov_iter_get_pages(&bio, iter);

Shouldn't this actually be done inside bio_iov_iter_get_pages?

It probably should... Should be trivial, I'll move it there instead.

-- 
Jens Axboe