Thread (31 messages) 31 messages, 5 authors, 2018-12-04

Re: [PATCH 3/7] nvme: implement mq_ops->commit_rqs() hook

From: Jens Axboe <axboe@kernel.dk>
Date: 2018-11-29 17:02:30
Also in: linux-nvme

On 11/29/18 8:47 AM, Christoph Hellwig wrote:
quoted
+static inline int nvme_next_ring_index(struct nvme_queue *nvmeq, u16 index)
+{
+	if (++index == nvmeq->q_depth)
+		return 0;
+
+	return index;
+}
This is unused now.
Huh, wonder how I missed that. GCC must not have complained.
Also what about this little cleanup on top?
That looks good, I like it. With that, can I add your reviewed-by? I'll
run a sanity check on it first.

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help