Re: [PATCH 7/7] blk-mq: use plug for devices that implement ->commits_rqs()
From: Christoph Hellwig <hch@infradead.org>
Date: 2018-11-29 15:50:18
Also in:
linux-nvme
From: Christoph Hellwig <hch@infradead.org>
Date: 2018-11-29 15:50:18
Also in:
linux-nvme
On Thu, Nov 29, 2018 at 07:49:59AM -0800, Christoph Hellwig wrote:
quoted
+ /* + * Use plugging if we have a ->commit_rqs() hook as well, + * as we know the driver uses bd->last in a smart + * fashion. + */Nipick: this could flow on just two lines: /* * Use plugging if we have a ->commit_rqs() hook as well, as we * know the driver uses bd->last in a smart fashion. */
But of course otherwise this looks fine: Reviewed-by: Christoph Hellwig <hch@lst.de>