Thread (23 messages) read the whole thread 23 messages, 5 authors, 2018-11-14

Re: [PATCH 5/6] blk-rq-qos: inline check for q->rq_qos functions

From: Christoph Hellwig <hch@infradead.org>
Date: 2018-11-14 15:40:45

On Wed, Nov 14, 2018 at 08:33:33AM -0700, Jens Axboe wrote:
quoted
The inlining sounds fine, but please do it without the obsfucating
macros.
Why? It's a lot of code duplication.
Just source code, not binary code.  And remember that humans want
to understand this code by grepping it, finding it in source browsers,
etc.  And all that macro obsfucation makes it much harder.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help