On 11/14/18 8:21 AM, Christoph Hellwig wrote:

On Sat, Nov 10, 2018 at 08:13:16AM -0700, Jens Axboe wrote:

quoted

Put the short code in the fast path, where we don't have any
functions attached to the queue. This minimizes the impact on
the hot path in the core code.

Cleanup duplicated code by having a macro setup both the inline
check and the actual functions.

The inlining sounds fine, but please do it without the obsfucating
macros.

Why? It's a lot of code duplication.

-- 
Jens Axboe