Thread (26 messages) 26 messages, 6 authors, 2018-09-27

Re: [PATCH v10 3/8] block: Split blk_pm_add_request() and blk_pm_put_request()

From: Christoph Hellwig <hch@lst.de>
Date: 2018-09-26 14:23:57

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

But one very minor nitpick below:
 #ifdef CONFIG_PM
+static inline void blk_pm_request_resume(struct request_queue *q)
+{
+	if (q->dev && (q->rpm_status == RPM_SUSPENDED ||
+		       q->rpm_status == RPM_SUSPENDING))
I usually try to break lines around related conditions, so more something
like:

	if (q->dev &&
	    (q->rpm_status == RPM_SUSPENDED || q->rpm_status == RPM_SUSPENDING))
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help