Thread (26 messages) 26 messages, 6 authors, 2018-09-27

Re: [PATCH v10 7/8] block: Make blk_get_request() block for non-PM requests while suspended

From: Christoph Hellwig <hch@lst.de>
Date: 2018-09-26 14:27:40

 		list_for_each_entry(rq, &q->queue_head, queuelist) {
-			if (blk_pm_allow_request(rq))
-				return rq;
-
-			if (rq->rq_flags & RQF_SOFTBARRIER)
-				break;
+#ifdef CONFIG_PM
+			/*
+			 * If a request gets queued in state RPM_SUSPENDED
+			 * then that's a kernel bug.
+			 */
+			WARN_ON_ONCE(q->rpm_status == RPM_SUSPENDED);
+#endif
I hate this ifdef, but it probably isnt worth adding a helper for this
assert, so I guess we'll have to live with it..

Otherwise this looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help