Re: [PATCH] bdi: Fix another oops in wb_workfn()
From: Jan Kara <jack@suse.cz>
Date: 2018-06-13 14:46:10
Also in:
linux-fsdevel, lkml
Possibly related (same subject, not in this thread)
- 2018-06-22 · Re: [PATCH] bdi: Fix another oops in wb_workfn() · Jens Axboe <axboe@kernel.dk>
- 2018-06-22 · Re: [PATCH] bdi: Fix another oops in wb_workfn() · Jan Kara <jack@suse.cz>
- 2018-06-19 · Re: [PATCH] bdi: Fix another oops in wb_workfn() · Jan Kara <jack@suse.cz>
- 2018-06-18 · Re: [PATCH] bdi: Fix another oops in wb_workfn() · Tejun Heo <tj@kernel.org>
- 2018-06-18 · Re: [PATCH] bdi: Fix another oops in wb_workfn() · Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
On Wed 13-06-18 19:43:47, Tetsuo Handa wrote:
Can't we utilize RCU grace period (like shown below) ?
Honestly, the variant 1 looks too ugly to me. However variant 2 looks mostly OK. We can also avoid the schedule_timeout_uninterruptible(HZ / 10) from your patch by careful handling of the bit waitqueues. Also I'd avoid the addition argument to wb_writeback() and split the function instead. The patch resulting from your and mine ideas is attached. Thoughts? Honza -- Jan Kara [off-list ref] SUSE Labs, CR
Attachments
- 0001-bdi-Fix-another-oops-in-wb_workfn.patch [text/x-patch] 5898 bytes · preview