Re: [PATCH] block drivers/block: Use octal not symbolic permissions
From: Joe Perches <joe@perches.com>
Date: 2018-05-23 22:35:39
Also in:
ceph-devel, lkml
From: Joe Perches <joe@perches.com>
Date: 2018-05-23 22:35:39
Also in:
ceph-devel, lkml
On Wed, 2018-05-23 at 15:27 -0600, Jens Axboe wrote:
On 5/23/18 2:05 PM, Joe Perches wrote:quoted
Convert the S_<FOO> symbolic permissions to their octal equivalents as using octal and not symbolic permissions is preferred by many as more readable. see: https://lkml.org/lkml/2016/8/2/1945 Done with automated conversion via: $ ./scripts/checkpatch.pl -f --types=SYMBOLIC_PERMS --fix-inplace <files...> Miscellanea: o Wrapped modified multi-line calls to a single line where appropriate o Realign modified multi-line calls to open parenthesisHonestly, I see this as pretty needless churn.
btw: There is currently a mixture of symbolic and octal permissions uses in block and drivers/block ie: 94 octal and 146 symbolic uses. If this is applied, all would become octal.