Thread (7 messages) 7 messages, 2 authors, 2018-05-24

Re: [PATCH] block drivers/block: Use octal not symbolic permissions

From: Joe Perches <joe@perches.com>
Date: 2018-05-23 21:41:38
Also in: ceph-devel, lkml
Subsystem: the rest · Maintainer: Linus Torvalds

On Wed, 2018-05-23 at 15:27 -0600, Jens Axboe wrote:
On 5/23/18 2:05 PM, Joe Perches wrote:
quoted
Convert the S_<FOO> symbolic permissions to their octal equivalents as
using octal and not symbolic permissions is preferred by many as more
readable.

see: https://lkml.org/lkml/2016/8/2/1945

Done with automated conversion via:
$ ./scripts/checkpatch.pl -f --types=SYMBOLIC_PERMS --fix-inplace <files...>

Miscellanea:

o Wrapped modified multi-line calls to a single line where appropriate
o Realign modified multi-line calls to open parenthesis
Honestly, I see this as pretty needless churn.
It's just for consistency and the ability to highlight
somewhat unusual permissions uses like just 0400.

Apply it at your leisure or ignore it.

btw: Joshua Morris' email address is bouncing.
Maybe it should be removed from MAINTAINERS.
---
 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9051a9ca24a2..0d546a10d0b9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5598,7 +5598,6 @@ F:	drivers/base/firmware_loader/
 F:	include/linux/firmware.h
 
 FLASH ADAPTER DRIVER (IBM Flash Adapter 900GB Full Height PCI Flash
Card)
-M:	Joshua Morris [off-list ref]
 M:	Philip Kelleher [off-list ref]
 S:	Maintained
 F:	drivers/block/rsxx/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help