Re: [PATCH 03/16] bcache: Annotate switch fall-through
From: Coly Li <hidden>
Date: 2018-03-15 15:49:22
On 15/03/2018 11:08 PM, Bart Van Assche wrote:
This patch avoids that building with W=1 triggers complaints about switch fall-throughs. Signed-off-by: Bart Van Assche <redacted>
Reviewed-by: Coly Li <redacted> Thanks. Coly Li
quoted hunk ↗ jump to hunk
--- drivers/md/bcache/util.c | 7 +++++++ 1 file changed, 7 insertions(+)diff --git a/drivers/md/bcache/util.c b/drivers/md/bcache/util.c index a23cd6a14b74..6198041f0ee2 100644 --- a/drivers/md/bcache/util.c +++ b/drivers/md/bcache/util.c@@ -32,20 +32,27 @@ int bch_ ## name ## _h(const char *cp, type *res) \ case 'y': \ case 'z': \ u++; \ + /* fall through */ \ case 'e': \ u++; \ + /* fall through */ \ case 'p': \ u++; \ + /* fall through */ \ case 't': \ u++; \ + /* fall through */ \ case 'g': \ u++; \ + /* fall through */ \ case 'm': \ u++; \ + /* fall through */ \ case 'k': \ u++; \ if (e++ == cp) \ return -EINVAL; \ + /* fall through */ \ case '\n': \ case '\0': \ if (*e == '\n') \