Thread (34 messages) 34 messages, 3 authors, 2018-01-08

Re: [PATCH v1 08/10] bcache: fix misleading error message in bch_count_io_errors()

From: Michael Lyle <hidden>
Date: 2018-01-03 17:14:22
Also in: linux-bcache

On 01/03/2018 06:03 AM, Coly Li wrote:
Bcache only does recoverable I/O for read operations by calling
cached_dev_read_error(). For write opertions there is no I/O recovery for
failed requests.

But in bch_count_io_errors() no matter read or write I/Os, before errors
counter reaches io error limit, pr_err() always prints "IO error on %,
recoverying". For write requests this information is misleading, because
there is no I/O recovery at all.

This patch adds a parameter 'is_read' to bch_count_io_errors(), and only
prints "recovering" by pr_err() when the bio direction is READ.

Signed-off-by: Coly Li <redacted>
Reviewed-by: Michael Lyle <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help