Thread (54 messages) 54 messages, 9 authors, 2017-11-02

Re: [PATCH 16/17] nvme: implement multipath access to nvme subsystems

From: Christoph Hellwig <hch@infradead.org>
Date: 2017-11-02 18:22:34
Also in: linux-nvme

On Mon, Oct 30, 2017 at 11:37:55AM +0800, Guan Junxiong wrote:
quoted
+	head->disk->flags = GENHD_FL_EXT_DEVT;
+	sprintf(head->disk->disk_name, "nvme%dn%d",
+			ctrl->subsys->instance, nsid);
Is it okay to use head->instance instead of nsid for disk name nvme#n# ?
Becuase _nsid_ sets are not continuous sometimes, so disk name is ugly in that case.
This actually was supposed to be the ns_head instance, that's why the
ns_ida moved to the subsystem.  I've fixed it up.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help