Thread (54 messages) 54 messages, 9 authors, 2017-11-02

Re: [PATCH 16/17] nvme: implement multipath access to nvme subsystems

From: Christoph Hellwig <hch@lst.de>
Date: 2017-10-28 06:32:52
Also in: linux-nvme

Sure this works?
It does.
nvme_req_needs_retry() checks blk_noretry_request():
The original idea here was to _set_ these bits on multipath path devices
so that they won't attempt any retry, but rather forward the I/O error
to the multipath device itself for failover.
So if these bits are set (as they should be for multipathed devices)
we'll never attempt any failover...
While that might have been the "original" idea, it isn't what this code
does.  We never set any of the REQ_FAILFAST_* bits in
nvme_ns_head_make_request.  In NVMe there aren't really any device
equivalents of REQ_FAILFAST_ that make sense for multipath.  The only
one that we map to is the limited retry bit, and that is media centric,
so a failver would not help.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help