Thread (50 messages) read the whole thread 50 messages, 6 authors, 2017-10-23

Re: [PATCH 10/17] nvme: switch controller refcounting to use struct device

From: Sagi Grimberg <sagi@grimberg.me>
Date: 2017-10-19 10:02:59
Also in: linux-nvme

quoted
I don't think the fabrics device does not help us to keep the ctrl
allocated until we finish removal.
All fabrics drivers grab an extra reference during ->create_ctrl,
which we will drop when releasing the file descriptor that we used
to create the device.

By the time we call ->delete_ctrl in nvmf_create_ctrl we must still
have that reference because we are still in a ->write call and thus
->release can't have been called yet.
Thanks for the clarification. Is it worth a preparatory patch to
change that before the ctrl device integration for change log
clarity?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help