On Thu, Oct 19, 2017 at 02:06:07PM +0300, Sagi Grimberg wrote:

Christoph,

quoted

  static void nvme_free_ns(struct kref *kref)
  {
  	struct nvme_ns *ns = container_of(kref, struct nvme_ns, kref);
  +	if (ns->head)
+		nvme_put_ns_head(ns->head);
+

When can we not have a ns-head set?

AFAICT, if nvme_alloc_ns succeeded, we have it set don't we?

Yes, I don't think we should need it.  Let me verify that for the
next round.