Re: [PATCH 8/9] nvme: track shared namespaces
From: Johannes Thumshirn <hidden>
Date: 2017-09-21 05:22:20
Also in:
linux-nvme
On Wed, Sep 20, 2017 at 04:54:36PM +0200, Christoph Hellwig wrote:
On Wed, Sep 20, 2017 at 10:36:43AM +0200, Johannes Thumshirn wrote:quoted
Being one of the persons who has to backport a lot of NVMe code to older kernels I'm not a huge fan of renaming nmve_ns.The churn is main main worry. Well and that I don't have a reall good name for what currently is nvme_ns either :)quoted
That said, I don't have a better name for nvme_ns_head (yet) but I'll try to think of one as well. OTOH looking at nvme_ns_head it actaully is the list head of the nvme_ns list.But head also has connotations in the SAN world. Maybe nvme_ns_chain?
I know that's why I didn't really like it all too much in the first place as well. For nvme_ns_chain, it's not a chain really (the list itself is a chain, the structure really is the list head...), but I suck at naming things so. -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg GF: Felix Imend�rffer, Jane Smithard, Graham Norton HRB 21284 (AG N�rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850