Re: [PATCH v2 2/2] blk-sysfs: return EINVAL when user modify nr_request less than BLKDEV_MIN_RQ
From: weiping zhang <hidden>
Date: 2017-09-21 17:12:31
From: weiping zhang <hidden>
Date: 2017-09-21 17:12:31
On Thu, Sep 21, 2017 at 10:38:22AM -0600, Jens Axboe wrote:
On 09/21/2017 09:17 AM, weiping zhang wrote:quoted
Signed-off-by: weiping zhang <redacted> --- block/blk-sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c index b8362c0..03a6e19 100644 --- a/block/blk-sysfs.c +++ b/block/blk-sysfs.c@@ -75,7 +75,7 @@ queue_requests_store(struct request_queue *q, const char *page, size_t count) return ret; if (nr < BLKDEV_MIN_RQ) - nr = BLKDEV_MIN_RQ; + return -EINVAL;This is potentially breaking existing scripts.
I just want this keep same behavior with the too larger case, If this may make other side effect, I drop this patch. Thanks weiping