Re: [PATCH 18/19] bcache: silence static checker warning
From: Coly Li <hidden>
Date: 2017-07-13 09:44:25
Also in:
linux-bcache
From: Coly Li <hidden>
Date: 2017-07-13 09:44:25
Also in:
linux-bcache
On 2017/7/1 上午4:43, bcache@lists.ewheeler.net wrote:
From: Dan Carpenter <redacted> In olden times, closure_return() used to have a hidden return built in. We removed the hidden return but forgot to add a new return here. If "c" were NULL we would oops on the next line, but fortunately "c" is never NULL. Let's just remove the if statement. Signed-off-by: Dan Carpenter <redacted> --- drivers/md/bcache/super.c | 3 --- 1 file changed, 3 deletions(-)diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 24cb9b7..243391d 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c@@ -1381,9 +1381,6 @@ static void cache_set_flush(struct closure *cl) struct btree *b; unsigned i; - if (!c) - closure_return(cl); - bch_cache_accounting_destroy(&c->accounting); kobject_put(&c->internal);
Agree, cache_set_flush() is only called from a continue_at() in __cache_set_unregister(). In this case, cl is always not NULL. Reviewed-by: Coly Li <redacted> Thanks. -- Coly Li