Re: Re: [PATCH 05/19] bcache: fix calling ida_simple_remove() with incorrect minor

(off-list ancestor, not in this archive)
[PULL] bcache fixes and updates for-4.13 · Eric Wheeler <hidden> · 2017-06-28
Re: [PULL] bcache fixes and updates for-4.13 · Christoph Hellwig <hch@infradead.org> · 2017-06-29
Re: [PULL] bcache fixes and updates for-4.13 · Coly Li <hidden> · 2017-06-29
Re: [PULL] bcache fixes and updates for-4.13 · Eric Wheeler <hidden> · 2017-06-29
Re: [PULL] bcache fixes and updates for-4.13 · Eric Wheeler <hidden> · 2017-06-29
[PATCH 13/19] bcache: delete redundant calling set_gc_sectors() · Tang Junhui <hidden> · 2017-06-30
[PATCH 05/19] bcache: fix calling ida_simple_remove() with incorrect minor · Tang Junhui <hidden> · 2017-06-30
[PATCH 03/19] bcache: do not subtract sectors_to_gc for bypassed IO · Tang Junhui <hidden> · 2017-06-30
[PATCH 16/19] bcache: increase the number of open buckets · Tang Junhui <hidden> · 2017-06-30
[PATCH 02/19] bcache: fix sequential large write IO bypass · Tang Junhui <hidden> · 2017-06-30
[PATCH 14/19] bcache: Correct return value for sysfs attach errors · Tony Asleson <hidden> · 2017-06-30
[PATCH 08/19] bcache: documentation for sysfs entries describing bcache cache hinting · Eric Wheeler <hidden> · 2017-06-30
[PATCH 07/19] bcache: introduce bcache sysfs entries for ioprio-based bypass/writeback hints · Eric Wheeler <hidden> · 2017-06-30
[PATCH 10/19] bcache: initialize stripe_sectors_dirty correctly for thin flash device · Tang Junhui <hidden> · 2017-06-30
[PATCH 09/19] bcache: update bio->bi_opf bypass/writeback REQ_ flag hints · Eric Wheeler <hidden> · 2017-06-30
[PATCH 01/19] bcache: Fix leak of bdev reference · Jan Kara <jack@suse.cz> · 2017-06-30
[PATCH 17/19] bcache: fix for gc and write-back race · Tang Junhui <hidden> · 2017-06-30
[PATCH 19/19] bcache: Update continue_at() documentation · Dan Carpenter <hidden> · 2017-06-30
[PATCH 18/19] bcache: silence static checker warning · Dan Carpenter <hidden> · 2017-06-30
[PATCH 09/19] bcache: update bio->bi_opf bypass/writeback REQ_ flag hints · Eric Wheeler <hidden> · 2017-06-30
[PATCH 13/19] bcache: delete redundant calling set_gc_sectors() · Tang Junhui <hidden> · 2017-06-30
[PATCH 01/19] bcache: Fix leak of bdev reference · Jan Kara <jack@suse.cz> · 2017-06-30
[PATCH 14/19] bcache: Correct return value for sysfs attach errors · Tony Asleson <hidden> · 2017-06-30
[PATCH 16/19] bcache: increase the number of open buckets · Tang Junhui <hidden> · 2017-06-30
[PATCH 18/19] bcache: silence static checker warning · Dan Carpenter <hidden> · 2017-06-30
[PATCH 19/19] bcache: Update continue_at() documentation · Dan Carpenter <hidden> · 2017-06-30
[PATCH 17/19] bcache: fix for gc and write-back race · Tang Junhui <hidden> · 2017-06-30
[PATCH 03/19] bcache: do not subtract sectors_to_gc for bypassed IO · Tang Junhui <hidden> · 2017-06-30
[PATCH 05/19] bcache: fix calling ida_simple_remove() with incorrect minor · Tang Junhui <hidden> · 2017-06-30
[PATCH 07/19] bcache: introduce bcache sysfs entries for ioprio-based bypass/writeback hints · Eric Wheeler <hidden> · 2017-06-30
[PATCH 02/19] bcache: fix sequential large write IO bypass · Tang Junhui <hidden> · 2017-06-30
[PATCH 10/19] bcache: initialize stripe_sectors_dirty correctly for thin flash device · Tang Junhui <hidden> · 2017-06-30
[PATCH 08/19] bcache: documentation for sysfs entries describing bcache cache hinting · Eric Wheeler <hidden> · 2017-06-30
[PATCH 01/19] bcache: Fix leak of bdev reference · <hidden> · 2017-06-30
[PATCH 02/19] bcache: fix sequential large write IO bypass · <hidden> · 2017-06-30
Re: [PATCH 02/19] bcache: fix sequential large write IO bypass · Christoph Hellwig <hch@infradead.org> · 2017-07-05
[PATCH 03/19] bcache: do not subtract sectors_to_gc for bypassed IO · <hidden> · 2017-06-30
Re: [PATCH 03/19] bcache: do not subtract sectors_to_gc for bypassed IO · Coly Li <hidden> · 2017-07-01
Re: [PATCH 03/19] bcache: do not subtract sectors_to_gc for bypassed IO · Christoph Hellwig <hch@infradead.org> · 2017-07-05
[PATCH 05/19] bcache: fix calling ida_simple_remove() with incorrect minor · <hidden> · 2017-06-30
Re: [PATCH 05/19] bcache: fix calling ida_simple_remove() with incorrect minor · Christoph Hellwig <hch@infradead.org> · 2017-07-05
Re: Re: [PATCH 05/19] bcache: fix calling ida_simple_remove() with incorrect minor · <hidden> · 2017-07-06
[PATCH 06/19] bcache: explicitly destory mutex while exiting · <hidden> · 2017-06-30
Re: [PATCH 06/19] bcache: explicitly destory mutex while exiting · Coly Li <hidden> · 2017-07-01
Re: [PATCH 06/19] bcache: explicitly destory mutex while exiting · Liang Chen <hidden> · 2017-07-05
Re: [PATCH 06/19] bcache: explicitly destory mutex while exiting · Coly Li <hidden> · 2017-07-11
Re: [PATCH 06/19] bcache: explicitly destory mutex while exiting · Christoph Hellwig <hch@infradead.org> · 2017-07-05
Re: [PATCH 06/19] bcache: explicitly destory mutex while exiting · Liang Chen <hidden> · 2017-07-06
[PATCH 07/19] bcache: introduce bcache sysfs entries for ioprio-based bypass/writeback hints · <hidden> · 2017-06-30
Re: [PATCH 07/19] bcache: introduce bcache sysfs entries for ioprio-based bypass/writeback hints · Christoph Hellwig <hch@infradead.org> · 2017-07-05
Re: [PATCH 07/19] bcache: introduce bcache sysfs entries for ioprio-based bypass/writeback hints · Eric Wheeler <hidden> · 2017-07-05
[PATCH 08/19] bcache: documentation for sysfs entries describing bcache cache hinting · <hidden> · 2017-06-30
Re: [PATCH 08/19] bcache: documentation for sysfs entries describing bcache cache hinting · Christoph Hellwig <hch@infradead.org> · 2017-07-05
[PATCH 09/19] bcache: update bio->bi_opf bypass/writeback REQ_ flag hints · <hidden> · 2017-06-30
Re: [PATCH 09/19] bcache: update bio->bi_opf bypass/writeback REQ_ flag hints · Coly Li <hidden> · 2017-07-01
Re: [PATCH 09/19] bcache: update bio->bi_opf bypass/writeback REQ_ flag hints · Eric Wheeler <hidden> · 2017-07-01
Re: [PATCH 09/19] bcache: update bio->bi_opf bypass/writeback REQ_ flag hints · Coly Li <hidden> · 2017-07-02
[PATCH 09/19 v2] bcache: update bio->bi_opf bypass/writeback REQ_ flag hints · <hidden> · 2017-07-03
Re: [PATCH 09/19 v2] bcache: update bio->bi_opf bypass/writeback REQ_ flag hints · Coly Li <hidden> · 2017-07-04
Re: [PATCH 09/19 v2] bcache: update bio->bi_opf bypass/writeback REQ_ flag hints · Christoph Hellwig <hch@infradead.org> · 2017-07-05
Re: [PATCH 09/19 v2] bcache: update bio->bi_opf bypass/writeback REQ_ flag hints · Coly Li <hidden> · 2017-07-06
Re: [PATCH 09/19 v2] bcache: update bio->bi_opf bypass/writeback REQ_ flag hints · Christoph Hellwig <hch@infradead.org> · 2017-07-06
Re: [PATCH 09/19 v2] bcache: update bio->bi_opf bypass/writeback REQ_ flag hints · Coly Li <hidden> · 2017-07-11
Re: [PATCH 09/19 v2] bcache: update bio->bi_opf bypass/writeback REQ_ flag hints · Coly Li <hidden> · 2017-07-12
[PATCH 10/19] bcache: initialize stripe_sectors_dirty correctly for thin flash device · <hidden> · 2017-06-30
Re: [PATCH 10/19] bcache: initialize stripe_sectors_dirty correctly for thin flash device · Coly Li <hidden> · 2017-07-01
Re: [PATCH 10/19] bcache: initialize stripe_sectors_dirty correctly for thin flash device · Eric Wheeler <hidden> · 2017-07-13
[PATCH 13/19] bcache: delete redundant calling set_gc_sectors() · <hidden> · 2017-06-30
Re: [PATCH 13/19] bcache: delete redundant calling set_gc_sectors() · Eric Wheeler <hidden> · 2017-07-13
[PATCH 14/19] bcache: Correct return value for sysfs attach errors · <hidden> · 2017-06-30
[PATCH 17/19] bcache: fix for gc and write-back race · <hidden> · 2017-06-30
Re: [PATCH 17/19] bcache: fix for gc and write-back race · Coly Li <hidden> · 2017-08-03
[PATCH 18/19] bcache: silence static checker warning · <hidden> · 2017-06-30
Re: [PATCH 18/19] bcache: silence static checker warning · Coly Li <hidden> · 2017-07-13
[PATCH 19/19] bcache: Update continue_at() documentation · <hidden> · 2017-06-30
Re: [PATCH 19/19] bcache: Update continue_at() documentation · Christoph Hellwig <hch@infradead.org> · 2017-07-05
Re: [PATCH 19/19] bcache: Update continue_at() documentation · Coly Li <hidden> · 2017-07-08
[PATCH 16/19] bcache: increase the number of open buckets · <hidden> · 2017-06-30
Re: [PATCH 16/19] bcache: increase the number of open buckets · Coly Li <hidden> · 2017-07-13
Re: [PATCH 01/19] bcache: Fix leak of bdev reference · Coly Li <hidden> · 2017-07-01
Re: [PATCH 01/19] bcache: Fix leak of bdev reference · Christoph Hellwig <hch@infradead.org> · 2017-07-05
Re: [PATCH 01/19] bcache: Fix leak of bdev reference · Coly Li <hidden> · 2017-09-04
Re: [PATCH 01/19] bcache: Fix leak of bdev reference · Christoph Hellwig <hch@infradead.org> · 2017-09-05
Re: [PATCH 01/19] bcache: Fix leak of bdev reference · Coly Li <hidden> · 2017-09-05
Re: [PATCH 01/19] bcache: Fix leak of bdev reference · Coly Li <hidden> · 2017-09-06

From: <hidden>
Date: 2017-07-06 06:21:05

Possibly related (same subject, not in this thread)

2017-07-01 · [PATCH 05/19] bcache: fix calling ida_simple_remove() with incorrect minor · Eric Wheeler <hidden>

Hello Christoph

quoted

+#define BCACHE_TO_IDA_MINORS(first_minor) ((first_minor) >>

BCACHE_MINORS_BITS)

quoted

+#define IDA_TO_BCACHE_MINORS(minor)       ((minor) <<

BCACHE_MINORS_BITS)

Please use inline functions and lower case for these.

I have send you a v2 patch, please have a review again.

Thanks
Tang Junhui

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help