Re: [PATCH v2 12/12] block: Rename blk_mq_rq_{to,from}_pdu()

[PATCH v2 00/12] More patches for kernel v4.13 · Bart Van Assche <hidden> · 2017-05-31
[PATCH v2 01/12] block: Make request operation type argument declarations consistent · Bart Van Assche <hidden> · 2017-05-31
[PATCH v2 02/12] block: Introduce request_queue.initialize_rq_fn() · Bart Van Assche <hidden> · 2017-05-31
Re: [PATCH v2 02/12] block: Introduce request_queue.initialize_rq_fn() · Christoph Hellwig <hch@lst.de> · 2017-06-01
[PATCH v2 03/12] block: Make most scsi_req_init() calls implicit · Bart Van Assche <hidden> · 2017-05-31
Re: [PATCH v2 03/12] block: Make most scsi_req_init() calls implicit · Christoph Hellwig <hch@lst.de> · 2017-06-01
[PATCH v2 04/12] block: Change argument type of scsi_req_init() · Bart Van Assche <hidden> · 2017-05-31
[PATCH v2 05/12] blk-mq: Initialize a request before assigning a tag · Bart Van Assche <hidden> · 2017-05-31
Re: [PATCH v2 05/12] blk-mq: Initialize a request before assigning a tag · Christoph Hellwig <hch@lst.de> · 2017-06-01
[PATCH v2 06/12] block: Add a comment above queue_lockdep_assert_held() · Bart Van Assche <hidden> · 2017-05-31
[PATCH v2 08/12] block: Document what queue type each function is intended for · Bart Van Assche <hidden> · 2017-05-31
Re: [PATCH v2 08/12] block: Document what queue type each function is intended for · Christoph Hellwig <hch@lst.de> · 2017-06-01
[PATCH v2 09/12] blk-mq: Document locking assumptions · Bart Van Assche <hidden> · 2017-05-31
Re: [PATCH v2 09/12] blk-mq: Document locking assumptions · Christoph Hellwig <hch@lst.de> · 2017-06-01
[PATCH v2 10/12] block: Constify disk_type · Bart Van Assche <hidden> · 2017-05-31
[PATCH v2 11/12] blk-mq: Warn when attempting to run a hardware queue that is not mapped · Bart Van Assche <hidden> · 2017-05-31
Re: [PATCH v2 11/12] blk-mq: Warn when attempting to run a hardware queue that is not mapped · Christoph Hellwig <hch@lst.de> · 2017-06-01
[PATCH v2 07/12] block: Check locking assumptions at runtime · Bart Van Assche <hidden> · 2017-05-31
Re: [PATCH v2 07/12] block: Check locking assumptions at runtime · Christoph Hellwig <hch@lst.de> · 2017-06-01
[PATCH v2 12/12] block: Rename blk_mq_rq_{to,from}_pdu() · Bart Van Assche <hidden> · 2017-05-31
Re: [PATCH v2 12/12] block: Rename blk_mq_rq_{to,from}_pdu() · Christoph Hellwig <hch@lst.de> · 2017-06-01
Re: [PATCH v2 12/12] block: Rename blk_mq_rq_{to,from}_pdu() · Bart Van Assche <hidden> · 2017-06-01
Re: [PATCH v2 12/12] block: Rename blk_mq_rq_{to,from}_pdu() · Jens Axboe <axboe@kernel.dk> · 2017-06-01
Re: [PATCH v2 12/12] block: Rename blk_mq_rq_{to,from}_pdu() · Bart Van Assche <hidden> · 2017-06-01
Re: [PATCH v2 12/12] block: Rename blk_mq_rq_{to,from}_pdu() · Jens Axboe <axboe@kernel.dk> · 2017-06-01
Re: [PATCH v2 12/12] block: Rename blk_mq_rq_{to,from}_pdu() · Jens Axboe <axboe@kernel.dk> · 2017-06-01

From: Jens Axboe <axboe@kernel.dk>
Date: 2017-06-01 19:04:54

On 05/31/2017 11:08 PM, Christoph Hellwig wrote:

On Wed, May 31, 2017 at 03:52:46PM -0700, Bart Van Assche wrote:

quoted

Commit 6d247d7f71d1 ("block: allow specifying size for extra command
data") added support for .cmd_size to blk-sq. Due to that patch the
blk_mq_rq_{to,from}_pdu() functions are also useful for single-queue
block drivers. Hence remove "_mq" from the name of these functions.
This patch does not change any functionality. Most of this patch has
been generated by running the following shell command:

I don't really see the point of this as it's primarily a blk-mq API
and we still hope to get rid of the old code.  But I'm not necessarily
against it either.

I agree, I think that's pointless churn.

-- 
Jens Axboe

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help