Thread (22 messages) 22 messages, 2 authors, 2017-06-06

Re: [PATCH v4 09/11] blk-mq: don't stop queue for quiescing

From: Bart Van Assche <hidden>
Date: 2017-06-05 21:36:45

On Mon, 2017-06-05 at 23:59 +0800, Ming Lei wrote:
quoted hunk ↗ jump to hunk
@@ -169,11 +169,7 @@ void blk_mq_quiesce_queue(struct request_queue *q)
 	unsigned int i;
 	bool rcu =3D false;
=20
-	__blk_mq_stop_hw_queues(q, true);
-
-	spin_lock_irq(q->queue_lock);
-	queue_flag_set(QUEUE_FLAG_QUIESCED, q);
-	spin_unlock_irq(q->queue_lock);
+	blk_mq_quiesce_queue_nowait(q);
=20
Although I would have preferred to keep blk_mq_quiesce_nowait() open-coded =
in
this function,

Reviewed-by: Bart Van Assche <redacted>=
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help