Thread (12 messages) 12 messages, 2 authors, 2017-06-30
STALE3303d

[PATCH 02/10] lightnvm: pblk: fix double-free on pblk init

From: Javier González <hidden>
Date: 2017-06-30 15:59:36
Also in: lkml
Subsystem: the rest · Maintainer: Linus Torvalds

Prevent pblk->lines being double freed in case of an error during pblk
initialization.

Fixes: dd2a43437337: "lightnvm: pblk: sched. metadata on write thread"
Reported-by: Dan Carpenter <redacted>
Signed-off-by: Javier González <redacted>
Signed-off-by: Matias Bjørling <redacted>
---
 drivers/lightnvm/pblk-init.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
index 8bdaf7e0e00b..b3fc310aa51c 100644
--- a/drivers/lightnvm/pblk-init.c
+++ b/drivers/lightnvm/pblk-init.c
@@ -812,8 +812,6 @@ static int pblk_lines_init(struct pblk *pblk)
 fail_free_lines:
 	while (--i >= 0)
 		pblk_free_line_bitmaps(&pblk->lines[i]);
-
-	kfree(pblk->lines);
 fail_free_bb_aux:
 	kfree(l_mg->bb_aux);
 fail_free_bb_template:
-- 
2.7.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help