[PATCH 10/10] lightnvm: pblk: set line bitmap check under debug
From: Javier González <hidden>
Date: 2017-06-30 15:59:06
Also in:
lkml
Subsystem:
the rest · Maintainer:
Linus Torvalds
Do bitmap checks only when debug mode is enable. The line bitmap used for mapping to physical addresses is fairly large (~512KB) and it is expensive to do this checks on the fast path. Signed-off-by: Javier González <redacted> Signed-off-by: Matias Bjørling <redacted> --- drivers/lightnvm/pblk-core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index e6f42cddc8ec..11fe0c5b2a9c 100644
--- a/drivers/lightnvm/pblk-core.c
+++ b/drivers/lightnvm/pblk-core.c@@ -1561,11 +1561,14 @@ static void pblk_line_should_sync_meta(struct pblk *pblk) void pblk_line_close(struct pblk *pblk, struct pblk_line *line) { struct pblk_line_mgmt *l_mg = &pblk->l_mg; - struct pblk_line_meta *lm = &pblk->lm; struct list_head *move_list; +#ifdef CONFIG_NVM_DEBUG + struct pblk_line_meta *lm = &pblk->lm; + WARN(!bitmap_full(line->map_bitmap, lm->sec_per_line), "pblk: corrupt closed line %d\n", line->id); +#endif spin_lock(&l_mg->free_lock); WARN_ON(!test_and_clear_bit(line->meta_line, &l_mg->meta_bitmap));
--
2.7.4