On 06/26/2017 01:36 PM, Andreas Dilger wrote:

On Jun 26, 2017, at 7:56 AM, Jens Axboe [off-list ref] wrote:

quoted

On 06/26/2017 03:59 AM, Christoph Hellwig wrote:

quoted

Looks mostly good,

but two nit-picks:

- can we keep a module option to disable streams, or in fact for
  now maybe to explicitly enable it?  I expect this to be interesting
  at least for the first devices that implement it.  Also given that
  it needs to be explicitly enabled I would expect some overhead of
  just enabling it when never used

Fine with me, I can add the 'streams' parameter back, but just default
it to false.

Better would be a parameter to set the default streams count, 0 by default.

The user should not need to know. If streams is enabled (bool), then it'll
ask for as many as we need on the block side right now, and scale down if
we have to. So I'd rather keep it as a "use streams or not" bool on the
nvme side.


-- 
Jens Axboe