On 06/27/2017 08:11 AM, Christoph Hellwig wrote:
On Mon, Jun 26, 2017 at 07:56:22AM -0600, Jens Axboe wrote:
quoted
quoted
- do we even need the < 4 streams fallback now that they are global
instead of per-ns instead of just disabling the feature for now?
Maybe the device only supports 2? or 3?
My crystal ball indicates that those are unlikely too see the
light. IFF we need to handle them we can still add code for it.
But we have to handle it, not doing so would be fragile. So our
options are:
1) Keep the stream_mappings[] array. It's simple, and it'll work
for any number of streams.
2) Kill stream_mappings[] and just do the MOD again.
I'd strongly lean towards #1. I don't have a lot of faith in
crystal balls.
--
Jens Axboe