Re: [PATCH v4 06/27] fs: check for writeback errors after syncing out buffers in generic_file_fsync
From: Matthew Wilcox <willy@infradead.org>
Date: 2017-05-10 12:48:36
Also in:
linux-btrfs, linux-cifs, linux-ext4, linux-f2fs-devel, linux-fsdevel, linux-mm, linux-nfs, linux-xfs, lkml
On Tue, May 09, 2017 at 11:49:09AM -0400, Jeff Layton wrote:
ext2 currently does a test+clear of the AS_EIO flag, which is is problematic for some coming changes. What we really need to do instead is call filemap_check_errors in __generic_file_fsync after syncing out the buffers. That will be sufficient for this case, and help other callers detect these errors properly as well. With that, we don't need to twiddle it in ext2. Suggested-by: Jan Kara <jack@suse.cz> Signed-off-by: Jeff Layton <redacted> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Matthew Wilcox <redacted>