Thread (49 messages) 49 messages, 6 authors, 2017-05-19

Re: [PATCH v4 11/27] fuse: set mapping error in writepage_locked when it fails

From: Jan Kara <jack@suse.cz>
Date: 2017-05-10 11:13:46
Also in: linux-btrfs, linux-cifs, linux-ext4, linux-f2fs-devel, linux-fsdevel, linux-mm, linux-nfs, linux-xfs, lkml

On Tue 09-05-17 11:49:14, Jeff Layton wrote:
This ensures that we see errors on fsync when writeback fails.

Signed-off-by: Jeff Layton <redacted>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Looks good to me. You can add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza
quoted hunk ↗ jump to hunk
---
 fs/fuse/file.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index ec238fb5a584..07d0efcb050c 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -1669,6 +1669,7 @@ static int fuse_writepage_locked(struct page *page)
 err_free:
 	fuse_request_free(req);
 err:
+	mapping_set_error(page->mapping, error);
 	end_page_writeback(page);
 	return error;
 }
-- 
2.9.3
-- 
Jan Kara [off-list ref]
SUSE Labs, CR
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help