Re: [PATCH 2/4] blk-mq: merge mq and sq make_request instances
From: Bart Van Assche <hidden>
Date: 2017-03-21 01:33:13
On 03/20/2017 04:39 PM, Christoph Hellwig wrote:=0A=
quoted hunk ↗ jump to hunk
@@ -1534,7 +1529,36 @@ static blk_qc_t blk_mq_make_request(struct request=
_queue *q, struct bio *bio)=0A=
}=0A=
=0A=
plug =3D current->plug;=0A=
- if (((plug && !blk_queue_nomerges(q)) || is_sync)) {=0A=
+ if (plug && q->nr_hw_queues =3D=3D 1) {=0A=
+ [ ... ]=0A=
+ } else if (((plug && !blk_queue_nomerges(q)) || is_sync)) {=0A=
struct request *old_rq =3D NULL;=0A=
=0A=
blk_mq_bio_to_request(rq, bio);=0A==0A= I think this patch will change the behavior for the plug =3D=3D NULL &&=0A= q->nr_hw_queues =3D=3D 1 && is_sync case: with this patch applied the code= =0A= under "else if" will be executed for that case but that wasn't the case=0A= before this patch.=0A= =0A= Bart.=0A=