On Mon, Mar 27, 2017 at 04:00:08PM +0000, Stephen  Bates wrote:

Thanks for the review Omar!

quoted

quoted

 
-unsigned int blk_stat_rq_ddir(const struct request *rq)
+int blk_stat_rq_ddir(const struct request *rq)
 {
-	return rq_data_dir(rq);
+	return (int)rq_data_dir(rq);

The cast here here isn't necessary, let's leave it off.

OK, I will add that in the respin!

quoted

quoted

 }
 EXPORT_SYMBOL_GPL(blk_stat_rq_ddir);
 

@@ -100,6 +100,8 @@ void blk_stat_add(struct request *rq)
 	list_for_each_entry_rcu(cb, &q->stats->callbacks, list) {
 		if (blk_stat_is_active(cb)) {
 			bucket = cb->bucket_fn(rq);
+			if (bucket < 0)
+				continue;

You also need to change the declaration of bucket to int above.

Ummmm, it is already is an int…

Yup, I was looking at the wrong place, sorry.