Re: [PATCH RFC 00/14] Add the BFQ I/O Scheduler to blk-mq

Il giorno 07 mar 2017, alle ore 01:22, Bart Van Assche =

[off-list ref] ha scritto:

=20
On 03/04/2017 08:01 AM, Paolo Valente wrote:

quoted

Some patch generates WARNINGS with checkpatch.pl, but these WARNINGS
seem to be either unavoidable for the involved pieces of code (which
the patch just extends), or false positives.

=20
The code in this series looks reasonably clean from a code style point
of view,

Great, thanks!

but please address all checkpatch warnings that can be
addressed easily. A few examples of such checkpatch warnings:
=20
ERROR: "foo * bar" should be "foo *bar"
=20

The offending line is:
*(__PTR) =3D (u64)__data * NSEC_PER_USEC;

so this seems a false positive.

WARNING: Symbolic permissions 'S_IRUGO|S_IWUSR' are not preferred.
Consider using octal permissions '0644'.
=20

I have used symbolic permissions because I find them much easier to
remember and decode than numeric constants, and because it is done so
in cfq-iosched.c, deadline-iosched.c and now mq-deadline.c.  But,
since you share this checkpatch complain, I will switch to constants.

Thanks,
Paolo

Thanks,
=20
Bart.