Thread (22 messages) 22 messages, 6 authors, 2017-02-08

Re: [PATCH 4/4] block: Make blk_get_backing_dev_info() safe without open bdev

From: Jan Kara <jack@suse.cz>
Date: 2017-02-01 12:28:14

On Wed 01-02-17 01:53:20, Christoph Hellwig wrote:
Looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>

But can you also add another patch to kill off blk_get_backing_dev_info?
The direct dereference is short and cleaner.  Additionally the bt_bdi
field in XFS could go away, too.
OK, I'll do that. Another cleanup I was considering is to remove all other
embedded occurences of backing_dev_info and make the structure only
dynamically allocated. It would unify the handling of backing_dev_info and
allow us to make bdi_init(), bdi_destroy(), etc. static inside
mm/backing_dev.c. What do you think?

								Honza
-- 
Jan Kara [off-list ref]
SUSE Labs, CR
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help