Thread (22 messages) 22 messages, 6 authors, 2017-02-08

Re: [PATCH 3/4] block: Dynamically allocate and refcount backing_dev_info

From: Jan Kara <jack@suse.cz>
Date: 2017-02-02 13:32:41

On Wed 01-02-17 14:45:20, Jens Axboe wrote:
On 02/01/2017 04:22 AM, Jan Kara wrote:
quoted
On Wed 01-02-17 01:50:07, Christoph Hellwig wrote:
quoted
On Tue, Jan 31, 2017 at 01:54:28PM +0100, Jan Kara wrote:
quoted
Instead of storing backing_dev_info inside struct request_queue,
allocate it dynamically, reference count it, and free it when the last
reference is dropped. Currently only request_queue holds the reference
but in the following patch we add other users referencing
backing_dev_info.
Do we really need the separate slab cache?  Otherwise this looks
fine to me.
Yeah, probably it is not worth it. I'll remove it.
I agree on that, it should not be a hot path. Will you respin the series
after making this change? Would be great to get this queued up.
Yes, will send it later today. I was just waiting whether someone else does
not have more comments to the series.

								Honza
-- 
Jan Kara [off-list ref]
SUSE Labs, CR
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help