Thread (25 messages) 25 messages, 3 authors, 2016-07-12

Re: [PATCH 08/13] pci: spread interrupt vectors in pci_alloc_irq_vectors

From: Alexander Gordeev <hidden>
Date: 2016-07-12 06:44:48
Also in: linux-nvme, linux-pci, lkml

On Sun, Jul 10, 2016 at 05:57:51AM +0200, Christoph Hellwig wrote:
On Thu, Jul 07, 2016 at 01:05:01PM +0200, Alexander Gordeev wrote:
quoted
irq_create_affinity_mask() bails out with no affinity in case of single
vector, but alloc_descs() (see below (*)) assigns the whole affinity
mask. It should be consistent instead.
I don't understand the comment.  If we only have one vector (of any
kinds) there is no need to create an affinity mask, we'll leave the
interrupt to the existing irq balancing code.
I got impression the affinity mask is assigned differently i.e. for
single MSI mode vs legacy mode. But I might be wrong here - I have to
look into the code again. Anyway, if it is the case it could be
addressed afterwards IMHO.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help