Re: [PATCH 07/13] pci: Provide sensible irq vector alloc/free routines
From: Alexander Gordeev <hidden>
Date: 2016-07-11 10:38:45
Also in:
linux-nvme, linux-pci, lkml
From: Alexander Gordeev <hidden>
Date: 2016-07-11 10:38:45
Also in:
linux-nvme, linux-pci, lkml
On Sun, Jul 10, 2016 at 05:47:37AM +0200, Christoph Hellwig wrote:
On Wed, Jul 06, 2016 at 10:05:45AM +0200, Alexander Gordeev wrote:quoted
quoted
+ pci_enable_msi, pci_enable_msi_range, pci_enable_msi_exact, pci_disable_msi, + pci_msi_vec_count, pci_enable_msix_range, pci_enable_msix_exact, + pci_disable_msix, pci_msix_vec_countDescription of these functions can be removed when all drivers migrated to the new API. Also implementation descriptions + examples would still be needed AFAICT.I diagreed - if we deprecated functions the only thing that should be mentioned is a "don't use these".
I will try to paraphrase myself. The new API deprecates pci_enable_msi*_range functions, but I am not that sure about others. Certainly, pci_msi*_vec_count and pci_enable_msi*_exact could have (and AFAIR do have) uses that can not be covered by automatic initialization of pci_alloc_irq_vectors().