Re: [PATCH v6 04/18] dt-bindings: soc: starfive: Add starfive,jh7110-hdmi-subsystem

From
Michal Wilczynski <m.wilczynski@samsung.com>
Date
2026-11-05 10:14:49
Also in
dri-devel, linux-devicetree, linux-riscv, linux-rockchip, lkml
Reply to
Conor Dooley, 2026-10-29

On 10/30/26 00:06, Conor Dooley wrote:
On Thu, Oct 29, 2026 at 08:53:38AM +0100, Michal Wilczynski wrote:
quoted
Add the dt-binding for the StarFive JH7110 HDMI subsystem.

The JH7110 HDMI IP is a monolithic block containing both the digital
controller and analog PHY in a single register space. This binding
defines the parent device, which holds the shared register map, and its
two children: the PHY and the controller.

The two have separate resources. The PHY takes the 24 MHz reference
clock and provides both the pixel clock, which the VOUT clock generator
routes on to the display controller, and the phy the controller uses.
The controller takes its clocks from the VOUT clock generator. What
they share is the register space, which the parent maps.

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
---
 .../starfive/starfive,jh7110-hdmi-subsystem.yaml   | 95 ++++++++++++++++++++++
 1 file changed, 95 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-hdmi-subsystem.yaml b/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-hdmi-subsystem.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..2ff8b0b920aec41a83f0aeaa0ed9c4249fe87f46
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-hdmi-subsystem.yaml
Why is this in bindings/soc? I feel like it should be in
bindings/display or something along those lines, since it's the display
subsystem of the device?

Cheers,
Conor.
Fair point - soc/ is mirroring where the drivers sit. I can relocate it
to bindings/display/starfive/ in v7, together with
starfive,jh7110-vout-subsystem.yaml, which also belongs to the display
subsystem.


Best regards,    
-- 
Michal Wilczynski [off-list ref]

Thread (30 messages) 30 messages, 4 authors, last reply 9d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help