Re: [PATCH v6 01/18] drm/bridge: inno-hdmi: fix swapped HSYNC and VSYNC polarity

From
Heiko Stuebner <heiko@sntech.de>
Date
2026-10-30 17:39:33
Also in
dri-devel, linux-devicetree, linux-riscv, linux-rockchip, lkml
Reply to
Michal Wilczynski, 2026-10-29
Am Donnerstag, 29. Oktober 2026, 08:53:35 Mitteleuropäische Normalzeit schrieb Michal Wilczynski:
v_HSYNC_POLARITY() and v_VSYNC_POLARITY() write the wrong bits: the
hardware puts HSYNC in bit 2 and VSYNC in bit 3, the macros do the
opposite. Most CEA modes drive both syncs with the same polarity so it
goes unnoticed; it only shows up on modes where the two differ.

Fixes: 412d4ae6b7a5 ("drm/rockchip: hdmi: add Innosilicon HDMI support")
Reported-by: Maud Spierings <redacted>
Closes: https://lore.kernel.org/all/e780ecb8-918f-4816-99c8-b69b10b25a18@murena.io/ (local)
Reported-by: Byron Stanoszek <redacted>
Closes: https://lore.kernel.org/all/b8b046ee-c574-3e16-6079-2fc415633dae@winds.org/ (local)
Suggested-by: Dominique Belhachemi <redacted>
Tested-by: Maud Spierings <redacted>
Tested-by: Byron Stanoszek <redacted>
Tested-by: OOHehir <redacted>
Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>

RK3036 TRM agrees with this assesment :-)

Reviewed-by: Heiko Stuebner <heiko@sntech.de>


Thread (30 messages) 30 messages, 4 authors, last reply 9d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help