Re: [PATCH v5 01/21] drm/bridge: inno-hdmi: fix swapped HSYNC and VSYNC polarity
From: Maud Spierings <hidden>
Date: 2026-10-01 15:40:14
Also in:
dri-devel, linux-clk, linux-devicetree, linux-phy, linux-riscv, linux-rockchip, lkml
Hi Michal, Fixed! Thanks! Tested-by: Maud Spierings <redacted> Kind regards, Maud On 9/29/26 12:30, Michal Wilczynski wrote:
quoted hunk ↗ jump to hunk
v_HSYNC_POLARITY() and v_VSYNC_POLARITY() write the wrong bits: the hardware puts HSYNC in bit 2 and VSYNC in bit 3, the macros do the opposite. Most CEA modes drive both syncs with the same polarity so it goes unnoticed; it only shows up on modes where the two differ. Fixes: 412d4ae6b7a5 ("drm/rockchip: hdmi: add Innosilicon HDMI support") Reported-by: Maud Spierings <redacted> Closes: https://lore.kernel.org/all/e780ecb8-918f-4816-99c8-b69b10b25a18@murena.io/ (local) Reported-by: Byron Stanoszek <redacted> Closes: https://lore.kernel.org/all/b8b046ee-c574-3e16-6079-2fc415633dae@winds.org/ (local) Suggested-by: Dominique Belhachemi <redacted> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> --- drivers/gpu/drm/bridge/inno-hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/gpu/drm/bridge/inno-hdmi.c b/drivers/gpu/drm/bridge/inno-hdmi.c index dd35f5a875d3d842fee6d2ead0de88503f9914e1..d7c33b92e2ddf4ced84d17304463f44be52270b8 100644 --- a/drivers/gpu/drm/bridge/inno-hdmi.c +++ b/drivers/gpu/drm/bridge/inno-hdmi.c@@ -122,8 +122,8 @@ enum { #define v_VIDEO_MUTE(n) ((n) << 0) #define HDMI_VIDEO_TIMING_CTL 0x08 -#define v_HSYNC_POLARITY(n) ((n) << 3) -#define v_VSYNC_POLARITY(n) ((n) << 2) +#define v_VSYNC_POLARITY(n) ((n) << 3) +#define v_HSYNC_POLARITY(n) ((n) << 2) #define v_INETLACE(n) ((n) << 1) #define v_EXTERANL_VIDEO(n) ((n) << 0)