Re: [PATCH] dt-bindings: arm: coresight: Allow funnel clocks
flat view
From: Leo Yan <leo.yan@arm.com>
Date: 2026-10-01 10:05:01
Also in:
linux-devicetree, lkml
Hi Rob, On Mon, Sep 21, 2026 at 06:28:33PM -0500, Rob Herring (Arm) wrote:
quoted hunk ↗ jump to hunk
Some static funnel nodes have APB and AT clocks. Allow one or two clocks and the apb_pclk and atclk clock-names entries. Assisted-by: LLM Signed-off-by: Rob Herring (Arm) <robh@kernel.org> --- .../bindings/arm/arm,coresight-static-funnel.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+)diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-static-funnel.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-static-funnel.yaml index 9598a3d0a95b..4a3d08f9568c 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-static-funnel.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-static-funnel.yaml@@ -30,6 +30,16 @@ properties: power-domains: maxItems: 1 + clocks: + minItems: 1 + maxItems: 2 + + clock-names: + minItems: 1 + items: + - const: apb_pclk + - const: atclk
The question is that a static funnel does not need to program any
registers, so in theory it should only need atclk as the module's core
clock, but not the APB programming clock (apb_pclk).
Maybe I did not get this right when I initially enabled the static
funnel in hi3660-coresight.dtsi. We should probably remove pclk from the
static funnel node.
clocks:
minItems: 0
maxItems: 1
clock-names:
minItems: 0
items:
- const: atclk
Thanks,
Leo