Some static funnel nodes have APB and AT clocks. Allow one or two
clocks and the apb_pclk and atclk clock-names entries.
Assisted-by: LLM
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
.../bindings/arm/arm,coresight-static-funnel.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)
@@ -30,6 +30,16 @@ properties:power-domains:maxItems:1+clocks:+minItems:1+maxItems:2++clock-names:+minItems:1+items:+-const:apb_pclk+-const:atclk+label:description:Description of a coresight device.
On Mon, 21 Sep 2026 18:28:33 -0500, Rob Herring (Arm) wrote:
Some static funnel nodes have APB and AT clocks. Allow one or two
clocks and the apb_pclk and atclk clock-names entries.
Assisted-by: LLM
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
.../bindings/arm/arm,coresight-static-funnel.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)
From: Leo Yan <leo.yan@arm.com> Date: 2026-10-01 10:05:01
Hi Rob,
On Mon, Sep 21, 2026 at 06:28:33PM -0500, Rob Herring (Arm) wrote:
quoted hunk
Some static funnel nodes have APB and AT clocks. Allow one or two
clocks and the apb_pclk and atclk clock-names entries.
Assisted-by: LLM
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
.../bindings/arm/arm,coresight-static-funnel.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)
The question is that a static funnel does not need to program any
registers, so in theory it should only need atclk as the module's core
clock, but not the APB programming clock (apb_pclk).
Maybe I did not get this right when I initially enabled the static
funnel in hi3660-coresight.dtsi. We should probably remove pclk from the
static funnel node.
clocks:
minItems: 0
maxItems: 1
clock-names:
minItems: 0
items:
- const: atclk
Thanks,
Leo
From: Rob Herring <robh@kernel.org> Date: 2026-10-01 12:04:46
On Thu, Oct 01, 2026 at 11:04:55AM +0100, Leo Yan wrote:
Hi Rob,
On Mon, Sep 21, 2026 at 06:28:33PM -0500, Rob Herring (Arm) wrote:
quoted
Some static funnel nodes have APB and AT clocks. Allow one or two
clocks and the apb_pclk and atclk clock-names entries.
Assisted-by: LLM
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
.../bindings/arm/arm,coresight-static-funnel.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)
The question is that a static funnel does not need to program any
registers, so in theory it should only need atclk as the module's core
clock, but not the APB programming clock (apb_pclk).
Maybe I did not get this right when I initially enabled the static
funnel in hi3660-coresight.dtsi. We should probably remove pclk from the
static funnel node.
Yes. I suppose in theory it has some clock, but if pclk needed to be
enabled, it is shared with all the other coresight components and
enabled anyways. And there's no atclk defined, so 'clocks' can just
be removed. Can you send a patch to do that, and I'll drop this one.
zynq7000 is even more of a mess I just noticed...
Rob
From: Leo Yan <leo.yan@arm.com> Date: 2026-10-01 13:41:25
On Thu, Oct 01, 2026 at 07:04:44AM -0500, Rob Herring wrote:
[...]
quoted
The question is that a static funnel does not need to program any
registers, so in theory it should only need atclk as the module's core
clock, but not the APB programming clock (apb_pclk).
Maybe I did not get this right when I initially enabled the static
funnel in hi3660-coresight.dtsi. We should probably remove pclk from the
static funnel node.
Yes. I suppose in theory it has some clock, but if pclk needed to be
enabled, it is shared with all the other coresight components and
enabled anyways. And there's no atclk defined, so 'clocks' can just
be removed. Can you send a patch to do that, and I'll drop this one.
Sure, I will prepare a patch for hi3660-coresight.dtsi.
zynq7000 is even more of a mess I just noticed...
Agreed. It should bind to "arm,coresight-dynamic-funnel" instead.
However, I'm afraid the "dbg_trc" and "dbg_apb" clocks are never touched
by either the CoreSight driver or the AMBA driver after switching to the
dynamic funnel. These clocks should therefore be removed from all
CoreSight nodes.
Thanks,
Leo