Re: [PATCH v4 02/11] media: imx8-isi: Extend output format mask to 7 bits
flat view
From: Frank Li <hidden>
Date: 2026-09-29 14:20:50
Also in:
imx, linux-devicetree, linux-media, lkml
On Tue, Sep 29, 2026 at 04:52:23PM +0800, Guoniu Zhou wrote:
The ISI output format field width differs across SoC generations: i.MX8 series (MN/MP/QM/QXP) use a 6-bit field (bits 29:24), while from i.MX8ULP onwards (including i.MX91/93/95/952) the field is extended to 7 bits (bits 30:24) to support RAW32 and RAW14 formats. Extend CHNL_IMG_CTRL_FORMAT_MASK to 7 bits unconditionally since bit 30 is unused on older platforms. Signed-off-by: Guoniu Zhou <redacted>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
quoted hunk ↗ jump to hunk
--- Changes in v3: - Use unconditional 7-bit mask instead of per-platform approach (Laurent) - Drop Reviewed-by from Frank Li due to significant change Changes in v2: - Add Reviewed-by tag from Frank Li --- drivers/media/platform/nxp/imx8-isi/imx8-isi-regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-regs.h b/drivers/media/platform/nxp/imx8-isi/imx8-isi-regs.h index e795f4daf3ff..c704be882705 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-regs.h +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-regs.h@@ -39,7 +39,7 @@ /* Channel Image Control Register */ #define CHNL_IMG_CTRL 0x0004 #define CHNL_IMG_CTRL_FORMAT(n) ((n) << 24) -#define CHNL_IMG_CTRL_FORMAT_MASK GENMASK(29, 24) +#define CHNL_IMG_CTRL_FORMAT_MASK GENMASK(30, 24) #define CHNL_IMG_CTRL_FORMAT_RGBA8888 0x00 #define CHNL_IMG_CTRL_FORMAT_ABGR8888 0x01 #define CHNL_IMG_CTRL_FORMAT_ARGB8888 0x02 --2.34.1