Re: [PATCH v8 10/14] Revert "crypto: qce - Mark QCE as BROKEN"
From: Demi Marie Obenour <hidden>
Date: 2026-09-22 05:43:03
Also in:
linux-arm-msm, linux-crypto, lkml
On 9/21/26 08:58, Bartosz Golaszewski wrote:
quoted hunk ↗ jump to hunk
The self-tests for this driver have been fixed. The crypto algorithms are only registered if the user explicitly requests it with the provided module parameter defaulting to false. There's no reason to further keep it unbuildable with the BROKEN label. While at it: update the Kconfig description by saying this is an "offloader" and not an "accelerator". Signed-off-by: Bartosz Golaszewski <redacted> --- arch/arm/configs/multi_v7_defconfig | 1 + arch/arm64/configs/defconfig | 1 + drivers/crypto/Kconfig | 16 ++++++++-------- 3 files changed, 10 insertions(+), 8 deletions(-)diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index f9b8dbf9318c9d4947e56ef0159311634bf0c1ee..2d6292f8cab39596b540084fbd8b30f4c25cd4ff 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig@@ -1323,6 +1323,7 @@ CONFIG_CRYPTO_DEV_ATMEL_AES=m CONFIG_CRYPTO_DEV_ATMEL_TDES=m CONFIG_CRYPTO_DEV_ATMEL_SHA=m CONFIG_CRYPTO_DEV_MARVELL_CESA=m +CONFIG_CRYPTO_DEV_QCE=m CONFIG_CRYPTO_DEV_ROCKCHIP=m CONFIG_CRYPTO_DEV_STM32_HASH=m CONFIG_CRYPTO_DEV_STM32_CRYP=mdiff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 982ea1758eb667a1949721140961764b3e9be1f6..55a2e8c3ae3522630df8c31cb2b7c7663e973aed 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig@@ -1957,6 +1957,7 @@ CONFIG_CRYPTO_AES_ARM64_CE_CCM=y CONFIG_CRYPTO_DEV_SUN8I_CE=m CONFIG_CRYPTO_DEV_FSL_CAAM=m CONFIG_CRYPTO_DEV_FSL_DPAA2_CAAM=m +CONFIG_CRYPTO_DEV_QCE=m CONFIG_CRYPTO_DEV_TEGRA=m CONFIG_CRYPTO_DEV_ZYNQMP_AES=m CONFIG_CRYPTO_DEV_ZYNQMP_SHA3=mdiff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index 0189dfdcbbe11098ead0ea194293422a31d8fe65..baf6c4a4c8aed663e89ae2468a7e9ed9dcb66f34 100644 --- a/drivers/crypto/Kconfig +++ b/drivers/crypto/Kconfig@@ -527,17 +527,17 @@ source "drivers/crypto/marvell/Kconfig" source "drivers/crypto/intel/Kconfig" config CRYPTO_DEV_QCE - tristate "Qualcomm crypto engine accelerator" - depends on (BROKEN && ARCH_QCOM) || COMPILE_TEST + tristate "Qualcomm crypto engine offloader" + depends on ARCH_QCOM || COMPILE_TEST depends on HAS_IOMEM help - This driver supports Qualcomm crypto engine accelerator - hardware. To compile this driver as a module, choose M here. The - module will be called qcrypto. + This driver supports Qualcomm crypto engine offloader hardware. To + compile this driver as a module, choose M here. The module will be + called qcrypto. - This driver does not have exclusive access to the - hardware, causing races with the secure world. It - is also slower than the CPU. + NOTE: This driver does not have exclusive access to the hardware, + causing races with the secure world. It is also *slower* than the + CPU for the same algorithms. Use at your own risk!
Would it make sense to clarify that this is only an issue if you pass do_register_algos=1? With do_register_algos=0 (the default), the driver is perfectly safe (unless you made a mistake elsewhere) and saves power, so most people want it on. Also, if I understand your previous messages correctly, Linux currently doesn't use any of the features that would cause the races with the secure world.
config CRYPTO_DEV_QCE_SKCIPHER bool
-- Sincerely, Demi Marie Obenour (she/her/hers)
Attachments
- OpenPGP_signature.asc [application/pgp-signature] 833 bytes