RE: [PATCH 3/5] arm64: dts: fsd: Move idle states out of CPUs node
From: "Alim Akhtar" <alim.akhtar@samsung.com>
Date: 2026-09-11 02:18:43
Also in:
linux-devicetree, linux-samsung-soc, lkml
-----Original Message----- From: Krzysztof Kozlowski <redacted> Sent: Wednesday, September 9, 2026 7:48 PM To: Alim Akhtar <alim.akhtar@samsung.com>; linux-fsd@tesla.com; Krzysztof Kozlowski [off-list ref]; Peter Griffin [off-list ref]; Rob Herring [off-list ref]; Conor Dooley [off-list ref] Cc: linux-arm-kernel@lists.infradead.org; linux-samsung- soc@vger.kernel.org; devicetree@vger.kernel.org; linux- kernel@vger.kernel.org; Krzysztof Kozlowski [off-list ref] Subject: [PATCH 3/5] arm64: dts: fsd: Move idle states out of CPUs node Idle states are not really part of CPUs, as often they have domain idle states, so move them level up to fix to fix dt-check-style warning: fsd.dtsi:300: [child-name-order] child node 'idle-states' out of name order Also, re-order properties to silence: fsd.dtsi:305: [property-order] property 'compatible' out of canonical order (should sort before 'idle-state-name') fsd.dtsi:308: [property-order] property 'entry-latency-us' out of canonical order (should sort before 'arm,psci-suspend-param') Signed-off-by: Krzysztof Kozlowski [off-list ref] ---
Probably this need to be done for many other SoCs and platforms Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
quoted hunk ↗ jump to hunk
arch/arm64/boot/dts/tesla/fsd.dtsi | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsib/arch/arm64/boot/dts/tesla/fsd.dtsi index d076ea634f4e..acbe93756a76 100644--- a/arch/arm64/boot/dts/tesla/fsd.dtsi +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi@@ -296,19 +296,19 @@ cpucl_l2: l2-cache0 { cache-line-size = <64>; cache-sets = <4096>; }; + }; - idle-states { - entry-method = "psci"; + idle-states { + entry-method = "psci"; - cpu_sleep: cpu-sleep { - idle-state-name = "c2"; - compatible = "arm,idle-state"; - local-timer-stop; - arm,psci-suspend-param = <0x0010000>; - entry-latency-us = <30>; - exit-latency-us = <75>; - min-residency-us = <300>; - }; + cpu_sleep: cpu-sleep { + compatible = "arm,idle-state"; + idle-state-name = "c2"; + local-timer-stop; + entry-latency-us = <30>; + exit-latency-us = <75>; + min-residency-us = <300>; + arm,psci-suspend-param = <0x0010000>; }; }; --2.53.0