Re: [PATCH v4 2/7] watchdog: mediatek: Add wdt/toprgu resets for mt6589
From: Luca Leonardo Scorcia <hidden>
Date: 2026-08-27 14:29:03
Also in:
linux-devicetree, linux-mediatek, linux-watchdog, lkml
quoted
drivers/watchdog/mtk_wdt.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c index 91d110646e16..f8208fb0f723 100644 --- a/drivers/watchdog/mtk_wdt.c +++ b/drivers/watchdog/mtk_wdt.c@@ -10,6 +10,7 @@ */ #include <dt-bindings/reset/mt2712-resets.h> +#include <dt-bindings/reset/mediatek,mt6589-wdt.h>I do not see how you use the bindings here, so my previous comments stay. You just ignored it and never replied. In such case: NAK
The mtk_wdt driver requires the total number of available resets to register the reset controller. This was defined as MT6589_TOPRGU_SW_RST_NUM in the binding header, therefore the need for including it. In your review for patch v4 1/7 [1] you mentioned that that define should be dropped as it's not really a binding, so for the next revision I'll drop that define from the binding header and move it directly inside the driver. The include won't then be necessary. Thank you for your help! [1] https://lists.infradead.org/pipermail/linux-mediatek/2026-August/112272.html -- Luca Leonardo Scorcia l.scorcia@gmail.com